On Sat, 19 Feb 2022 16:51:52 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test case for line straightness check > > tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line > 172: > >> 170: continue; >> 171: else >> 172: fail("Each pixel color of line should be" + >> line_color + " but was:" + expected); > > The name `expected` is misleading. It isn't the expected value, but rather > the "actual" value that you just read. > > Also, there are two formatting issues: > 1. There should be a space after the `if` > 2. The target statements of the `if` and `else` must be surrounded by curly > braces (unless on the same line as the `if` which would look odd in this case) done ------------- PR: https://git.openjdk.java.net/jfx/pull/731