On Tue, 1 Mar 2022 10:00:58 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up test and fix
>
> modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line 850:
>
>> 848: return Exception { SecurityError };
>> 849:
>> 850: if (m_localStorage)
>
> Let's enclose this change in `#if PLATFORM(JAVA)` macro. It makes easy to
> identify Java platform specific changes and handle merging when updating
> WebKit.
done
> modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java
> line 49:
>
>> 47: import javafx.concurrent.Worker;
>> 48: import javafx.scene.web.WebView;
>> 49: import javafx.scene.web.WebEngine;
>
> Several import statements can be removed. Only below imports are sufficient
> to run the test, others can be removed.
>
> import static org.junit.Assert.assertEquals;
> import static org.junit.Assert.assertTrue;
> import static org.junit.Assert.assertNotNull;
> import org.junit.AfterClass;
> import org.junit.Test;
>
> import java.io.File;
> import java.io.IOException;
>
> import javafx.scene.web.WebView;
> import javafx.scene.web.WebEngine;
done
-------------
PR: https://git.openjdk.java.net/jfx/pull/703
