On Fri, 15 Apr 2022 23:29:54 GMT, Alexander Matveev <almat...@openjdk.org> 
wrote:

>> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0.
>> - No changes to our code, except in GstAudioSpectrum.cpp 
>> g_atomic_pointer_compare_and_exchange() was changed to 
>> g_atomic_pointer_set(). For some reason I was not able to get code compiled 
>> with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do 
>> not see a need to use g_atomic_pointer_compare_and_exchange(), since 
>> m_pHolder always equals to old_holder.
>> - Tested on all platforms with all supported media streams.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8283218: Update GStreamer to 1.20.1 [v3]

Update GStreamer to 1.20.1 [v2]
 - Made caps writable before changing them in qtdemux, otherwise values are not 
set and critical error printed in console.
 - Fixed compilation error in GstAudioSpectrum.cpp by casting pointer.
 - Added g_abort() if it is not defined (building with older GLib).

Update GStreamer to 1.20.1 [v3]
 - Added -Werror=deprecated-declarations and 
GLIB_VERSION_MIN_REQUIRED/GLIB_VERSION_MAX_ALLOWED=2.48.0 to Linux makefiles. 
GLIB_VERSION_MIN_REQUIRED/GLIB_VERSION_MAX_ALLOWED will give deprecated 
warnings when code uses APIs from GLib which where added after 2.48.0. 
-Werror=deprecated-declarations will fail build if such warning detected. This 
is needed to make sure that we can build and run with older GLib starting with 
2.48.0 and up.
 - avplugin does not have -Werror=deprecated-declarations, because avplugin 
uses deprecated APIs from libavcodec and build fails with this flag and fixing 
avplugin is out of scope of GStreamer update.
 - Fixed build issues that were discovered after above was implemented, so we 
can build/run with GLib 2.48.0 and up.

-------------

PR: https://git.openjdk.java.net/jfx/pull/768

Reply via email to