On Thu, 21 Apr 2022 11:23:35 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
> This PR is to cleanup a few `javafx.controls` unit tests that were ignored. > > Here is the list of targeted unit test classes- > - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`, > `PaginationTest` > - Ignored tests removed - `RadioMenuItemTest`, `PopupControlTest` > > Results of `javafx.controls` unit tests- > **Before this PR :** > Total tests - 8610 > Failures - 0 > Ignored - 246 > > **After this PR :** > Total tests - 8608 > Failures - 0 > Ignored - 235 Looks good to me, Providing minor suggestions. modules/javafx.controls/src/test/java/test/javafx/scene/control/CellTest.java line 387: > 385: cell.requestFocus(); > 386: Toolkit.getToolkit().firePulse(); > 387: Minor: Optional: Adding `assertTrue(cell.isEditing());` here can be a good sanity check. But I leave it to you. Similar comment for the change in `DateCellTest.loseFocusWhileEditing()` modules/javafx.controls/src/test/java/test/javafx/scene/control/CellTest.java line 392: > 390: > 391: assertFalse(cell.isEditing()); > 392: } I would recommend to call `stage.hide()` similar to that in the `@AfterClass cleanup` methods. Similar comment for the change in `DateCellTest.loseFocusWhileEditing()` ------------- Changes requested by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/780
