On Mon, 8 Aug 2022 20:30:01 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs in .settings/
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains eight additional
> commits since the last revision:
>
> - 8290473: junit 5
> - Merge remote-tracking branch 'origin/master' into 8290473.apps
> - 8290473: removed eclipse project in buildSrc
> - 8290473: whitespace
> - 8290473: added initDirs task
> - Merge remote-tracking branch 'origin/master' into 8290473.apps
> - 8290473: added ColorCube project
> - 8290473: eclipse config for apps
Regarding the `build.gradle` changes, I think it's better to create the needed
dirs in the `:graphics` project rather than in the configure step of the global
`sdk` task.
build.gradle line 4176:
> 4174:
> 4175: task sdk() {
> 4176: dependsOn(initDirs)
I think this should be done in the graphics project, closer to the build logic
for the shaders, maybe something like this:
--- a/build.gradle
+++ b/build.gradle
@@ -2501,6 +2501,15 @@ project(":graphics") {
}
}
+ task initShaderDirs() {
+ doLast {
+ // Create empty hlsl dirs on all platforms for IDE support
+ file("$project.buildDir/hlsl/Decora").mkdirs()
+ file("$project.buildDir/hlsl/Prism").mkdirs()
+ }
+ }
+ project.processShaders.dependsOn(initShaderDirs)
+
nativePrism.dependsOn compilePrismHLSLShaders;
project.nativeAllTask.dependsOn nativeDecora
-------------
PR: https://git.openjdk.org/jfx/pull/858
