On Tue, 16 Aug 2022 21:48:37 GMT, Kevin Rushforth <[email protected]> wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed dpqs javadoc + tests (setupOnce)
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/DualPivotQuicksort20191112Ext.java
> line 52:
>
>> 50: public final class DualPivotQuicksort20191112Ext {
>> 51:
>> 52: private static final boolean FAST_ISORT = true;
>
> How much testing have you done with this flag set to true?
This is a validated shortcut as dpqs main loop also uses insertionsort on small
arrays too, functionally equivalent.
> modules/javafx.graphics/src/main/java/com/sun/marlin/DualPivotQuicksort20191112Ext.java
> line 784:
>
>> 782: * @param srcB the source array for the secondary array to be
>> ordered (b)
>> 783: * @param offset the start index in the source, inclusive
>> 784: * @param dstB the temporary buffer used in merging (b)
>
> Minor: this should probably be moved before `offset`
Sure, will fix this line before integration
-------------
PR: https://git.openjdk.org/jfx/pull/674
