On Wed, 17 Aug 2022 20:26:12 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits since the last revision: >> >> - Merge branch 'openjdk:master' into 8290473.apps >> - Merge branch 'openjdk:master' into 8290473.apps >> - 8290473: removed empty src sir >> - 8290473: whitespace >> - 8290473: init shader dirs >> - 8290473: junit 5 >> - Merge remote-tracking branch 'origin/master' into 8290473.apps >> - 8290473: removed eclipse project in buildSrc >> - 8290473: whitespace >> - 8290473: added initDirs task >> - ... and 3 more: https://git.openjdk.org/jfx/compare/f4048f6d...e86cb390 > > apps/toys/.classpath line 9: > >> 7: </classpathentry> >> 8: <classpathentry kind="src" path="FX8-3DFeatures/src"/> >> 9: <classpathentry kind="src" path="Hello/src/main/java"/> > > Why are these the only 2 sources? the goal of this PR is to make a workable configuration. We have a separate ticket JDK-8221708 for apps and toys. > build.gradle line 2508: > >> 2506: // Create empty hlsl dirs on all platforms for IDE support >> 2507: file("$project.buildDir/hlsl/Decora").mkdirs() >> 2508: file("$project.buildDir/hlsl/Prism").mkdirs() > > You need to create `build/gensrc/jsl-decora` and `build/gensrc/jsl-prism` too > if they are not declared as optional sources in the classpath. ok > buildSrc/.settings/org.eclipse.core.resources.prefs line 2: > >> 1: eclipse.preferences.version=1 >> 2: encoding/<project>=UTF-8 > > This file can be removed too since buildSrc is not a project. ok ------------- PR: https://git.openjdk.org/jfx/pull/858
