On Wed, 17 Aug 2022 16:36:24 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Accessibility is not implemented for JavaFX dialogs. This change is to >> implement the accessibility on windows platform. >> Without this fix : On Windows platform, content of Dialog are not read by >> Windows Narrator or JAWS. >> With this fix: >> 1. Windows narrator reads the dialog correctly >> 2. JAWS fails to read the header text. : This will be handled separately >> 3. Behavior of VoiceOver on MacOS remains unchanged : This will be handled >> separately. >> >> Verification: >> 1. Run HelloAlert toy app, with fix. >> 2. Start Windows Narrator >> 3. Click on the different buttons to show different Dialogs >> => Observe that Narrator reads all the content correctly. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > review comment, add since 20 Looks good to me! ------------- Marked as reviewed by aghaisas (Reviewer). PR: https://git.openjdk.org/jfx/pull/873
