On Sun, 21 Aug 2022 11:54:05 GMT, Jeanette Winzenburg <[email protected]> wrote:
> Fix and tests look rather complete, NPEs are fixed > > There is still one unguarded access to the selectionModel in > ListViewSkin.queryAccessibleAttributes: don't know if that's ever reached > without actually having a selectionModel? > > As we have similar NPEs in all our behaviors (of virtualized controls), we > might decided here which behavior we want to support and then apply that > decision everywhere. In particular what should happen if we have a null > selection and a not-null focusModel with > > * activate/edit: that happens on the focusedIndex/Cell with selection only an > after-thought > * focus navigation (often ctrl-somekey): is inconsistently either supported > (ctrl-end) or not (ctrl-pageDown) > > Personally, I think that we should support both - we have a separate > focusModel so should use it independently of the selectionModel where > possible. A good starter for this issue might be to implement the activate > such that it doesn't back out on null selection (just leave out the select > statement). The consistent support of navigation might be done in a follow-up > issue. `queryAccessibleAttributes` is now fixed, as well as the other things you mentioned. :) ------------- PR: https://git.openjdk.org/jfx/pull/711
