On Wed, 28 Sep 2022 16:20:59 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8292353: review comments > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewRowTest.java > line 120: > >> 118: assertFalse(row.isSelected()); >> 119: } >> 120: } > > Unless you are certain that they are covered elsewhere (not counting anything > in `TreeAndTableViewTest`), having similar test methods to the above with > cell selection disabled would be useful. yes, these cases are covered in TableViewSelectionModelImplTest ------------- PR: https://git.openjdk.org/jfx/pull/875
