On Fri, 4 Nov 2022 14:15:43 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> Any comments on this? > > hmm .. maybe this is a mis-understanding: > > - the case selected_items looks fishy (also in the original) - seems to not > return if the selection is empty or now if the selection is null > - every known case should return under any condition, IMO, delegating to > super is done only for unhandled cases > > Also, selected_items looks weird to return from inside the loop across the > selected cells on the very first iteration. Might be a bug. > > BTW: did I ever mention that we need tests for everything we change ;) See > the equivalent fix for ListView for how to .. And thank you @kleopatra for reference and reminder about test. Out of this comes [JDK-8296413](https://bugs.openjdk.org/browse/JDK-8296413) TableView with null focus model throws NPE in queryAccessibleAttribute(AccessibleAttribute.FOCUS_ITEM) ------------- PR: https://git.openjdk.org/jfx/pull/876
