On Tue, 27 Sep 2022 19:36:46 GMT, Andy Goryachev <[email protected]> wrote:
> Using new Skin.install() method to properly install and uninstall > inputMethodTextChanged and inputMethodRequests properties on TextInputControl. > > This avoids memory leaks resulting from skin change, as well as honors > user-set properties when installing an uninstalling. > > This PR depends on [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) > Skin.install(). If this is changed to adding an `EventHandler` rather than calling `setOnInputMethodTextChanged`, do you still want / need to move the initialization logic to the `Skin::install` method? I presume you do, so we will need to highlight the potential behavioral incompatibility, in the API docs (maybe via an `@implNote`, since the only compatibility concern is with subclasses that make assumptions about undocumented behavior of their superclass) or a release note or both. ------------- PR: https://git.openjdk.org/jfx/pull/903
