On Sun, 13 Nov 2022 01:41:45 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary add-exports attribute from Eclipse files > > tests/manual/controls/.classpath line 10: > >> 8: <classpathentry combineaccessrules="false" kind="src" path="/graphics"> >> 9: <attributes> >> 10: <attribute name="add-exports" >> value="javafx.graphics/com.sun.glass.ui=ALL-UNNAMED:javafx.graphics/com.sun.glass.ui.monocle=ALL-UNNAMED:javafx.graphics/com.sun.javafx.sg.prism=ALL-UNNAMED:javafx.graphics/com.sun.prism.impl=ALL-UNNAMED:javafx.graphics/com.sun.javafx.image.impl=ALL-UNNAMED:javafx.graphics/com.sun.glass.events=ALL-UNNAMED:javafx.graphics/com.sun.javafx.application=ALL-UNNAMED:javafx.graphics/com.sun.javafx.css=ALL-UNNAMED:javafx.graphics/com.sun.javafx.geom=ALL-UNNAMED:javafx.graphics/com.sun.javafx.tk=ALL-UNNAMED:javafx.graphics/com.sun.glass.ui.mac=ALL-UNNAMED"/> > > The wrong attribute was removed. The module one should stay, the exports one > should be removed. A bit overeager there, sorry I missed it. I've added it back. ------------- PR: https://git.openjdk.org/jfx/pull/930
