On Wed, 23 Nov 2022 00:57:11 GMT, Alexander Matveev <almat...@openjdk.org> 
wrote:

> This is regression from 
> [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352). 
> [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352) moved clearing 
> pending events in progress buffer when upstream sends EOS. We need to do this 
> for any other events except EOS. If we clear pending EOS, then it will not be 
> delivered and we will hang due to downstream waiting for data or EOS. We 
> still need to clear any other events such as new segment and not deliver it 
> once we receive EOS.
> 
> Added "plugins" folder to macOS project. For some reason it was missing and 
> debugging plugins with xcode was not possible.
> 
> Tested on all platforms with all formats over FILE and HTTP protocol. EOS was 
> delivered correctly in all cases.

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/961

Reply via email to