On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond >> operators (ecj has no issues). I had two options, add a >> `SuppressWarnings("unused")` or to use a lambda instead of a method >> reference to make `javac` happy. I choose the later and added a comment so >> it can be fixed once the bug is fixed. I've reported the issue here: >> https://bugs.openjdk.org/browse/JDK-8297428 >> >> - Remove unsupported/unnecessary SuppressWarning annotations >> - Remove reduntant type specifications (use diamond operator) >> - Remove unused or duplicate imports >> - Remove unnecessary casts (type is already correct type or can be autoboxed) >> - Remove unnecessary semi-colons (at end of class definitions, or just >> repeated ones) >> - Remove redundant super interfaces (interface that is already inherited) >> - Remove unused type parameters >> - Remove declared checked exceptions that are never thrown >> - Add missing `@Override` annotations > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Revert instanceof changes and replace with null checks modules/javafx.controls/src/test/java/test/javafx/scene/chart/ValueAxisTest.java line 172: > 170: > 171: @Test public void > checkScaleIsReadOnlyPropertyAndHenceCannotBeBound() { > 172: assertTrue(axis.scaleProperty() instanceof > ReadOnlyDoubleProperty); This also seems potentially useful for the same reason I mentioned above. ------------- PR: https://git.openjdk.org/jfx/pull/959