On Sat, 3 Dec 2022 20:54:04 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations >> - Remove reduntant type specifications (use diamond operator) >> - Remove unused or duplicate imports >> - Remove unnecessary casts (type is already correct type or can be autoboxed) >> - Remove unnecessary semi-colons (at end of class definitions, or just >> repeated ones) >> - Remove redundant super interfaces (interface that is already inherited) >> - Remove unused type parameters >> - Remove declared checked exceptions that are never thrown >> - Add missing `@Override` annotations > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Fix indentations and merge short lines > This is one giant pull request, somewhat difficult on the reviewers, > especially since we have to go through it several times. > > It would be _much_ easier for the reviewers to deal with one fix per PR, > especially in the cases where more than 30 files are going to be touched. > > For example, changes involving diamond operator and missing @OVERRIDES could > have been made into two separate PRs, making it a breeze to review and > integrate, while also cutting down on the number of files which contained > non-trivial changes. > > What do you think? Agreed, they'll be smaller and more focused in the future. ------------- PR: https://git.openjdk.org/jfx/pull/960
