On Wed, 30 Nov 2022 12:48:10 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> If the casts in the numerator actually matter, then the cast in the >> denominator can be removed. The latter are the ones that Eclipse flags for >> me as unnecessary. > > I still think that any change here would be a very low value change. If done > incorrectly, as it was in the initial attempt, it can introduce bugs. Even if > done correctly, I see no point in it. I don't really mind either way. Eclipse's refactoring are safe, so I don't see any risk in doing what it says (removing the denominator casts). For me, the less casts the more clear what the calculation is doing. Like I said before, it's probably a personal thing. ------------- PR: https://git.openjdk.org/jfx/pull/960
