On Thu, 8 Dec 2022 19:21:14 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/DatePickerSkin.java > line 145: > >> 143: show(); >> 144: } else { >> 145: updateDisplayNode(); > > Can the call to `updateDisplayNode();` be removed in line 128 then? > Just asking, since `updateDisplayNode();` is now called two times. But it > looks like this is also still needed.. I believe `updateDisplayNode()` in line 128 is required as it is the event handler on `valueProperty`. ------------- PR: https://git.openjdk.org/jfx/pull/963