On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing >> focus handling with event propagation. Since #852, >> `KeyHandler.setFocusVisible` is also called from mouse and touch event >> handlers, which makes the purpose of the class even less pronounced. >> >> Moving the focus-related functionality next to the other focus functions in >> the `Scene` class makes it easier to work with the code in the future. >> >> With the focus-related functions gone, `KeyHandler` only contains a single, >> small method that is called from `Scene.processKeyEvent`. For simplicity, >> this code can be rolled into `Scene.processKeyEvent` and the now-empty >> `KeyHandler` class can be removed. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - Merge branch 'master' into fixes/keyhandler-refactor > - review changes > - Removed KeyHandler Marked as reviewed by arapte (Reviewer). ------------- PR: https://git.openjdk.org/jfx/pull/962
