On Fri, 20 Jan 2023 12:39:03 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Ajit Ghaisas has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Additional review fixes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ComboBox.java line 
> 147:
> 
>> 145:  * a custom {@link #cellFactoryProperty() cell factory}.</li>
>> 146:  * </ul>
>> 147:  * <p>The following minimal example shows how to create a custom cell 
>> factory for {@code ComboBox} containing {@link Node}s:
> 
> Can you also add the final note, after the example, about creating the 
> Rectangle in the instance init block or constructor?

Done!

-------------

PR: https://git.openjdk.org/jfx/pull/995

Reply via email to