On Thu, 26 Jan 2023 18:20:52 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - JDK-8269907
>> Added missing changes after merge
>> - Merge remote-tracking branch 'origjfx/master' into
>> JDK-8269907-dirty-and-removed
>>
>> # Conflicts:
>> # modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java
>> # modules/javafx.graphics/src/main/java/javafx/scene/Scene.java
>> - Merge remote-tracking branch 'origin/master'
>> - JDK-8269907
>> Removed the sync methods for the scene, because they don't work when peer
>> is null, and they are not necessary.
>> - JDK-8269907
>> Fixed rare bug, causing bounds to be out of sync.
>> - JDK-8269907
>> We now require the rendering lock when cleaning up dirty nodes. To do so,
>> we moved some code required for snapshot into a reusable method.
>> - JDK-8269907
>> The bug is now fixed in a new way. Toolkit now supports registering
>> CleanupListeners, which can clean up the dirty nodes, avoiding memoryleaks.
>> - JDK-8269907
>> Fixing dirty nodes and parent removed, when a window is no longer
>> showing. This typically happens with context menus.
>
> tests/system/src/test/java/test/javafx/scene/DirtyNodesLeakTest.java line 44:
>
>> 42: import static test.util.Util.TIMEOUT;
>> 43:
>> 44: public class DirtyNodesLeakTest {
>
> Since this tests dirty nodes of a `Scene`, maybe you could use a name like
> `Scene_dirtyNodesLeakTest`?
I like the name you've suggested. I've changed it now to your suggestion.
-------------
PR: https://git.openjdk.org/jfx/pull/584
