> While checking for duplicate series addition to the line chart, `setToRemove` > value was not considered before throwing exception. Hence code to handling > the case of adding the removed series was never run. > > Added condition to check `setToRemove` boolean value before throwing > exception. Made changes to call `setChart` method after calling > `seriesBeingRemovedIsAdded`. Otherwise chart will not be drawn for the > series, only points will be plotted. > > This issue is reproducible only when animation is enabled because timeline > will be still running when removed series is added back to the same chart. > Since timeline does not run in unit tests, added system test to validate the > fix.
Karthik P K has updated the pull request incrementally with two additional commits since the last revision: - Renamed system test file - Fixing issue in all XYCharts ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1015/files - new: https://git.openjdk.org/jfx/pull/1015/files/6f59b6d7..0282896e Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1015&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1015&range=00-01 Stats: 533 lines in 7 files changed: 382 ins; 134 del; 17 mod Patch: https://git.openjdk.org/jfx/pull/1015.diff Fetch: git fetch https://git.openjdk.org/jfx pull/1015/head:pull/1015 PR: https://git.openjdk.org/jfx/pull/1015
