On Tue, 7 Feb 2023 20:06:27 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java > line 365: > >> 363: } >> 364: >> 365: String cleanText = getCleanText(); > > cleanText code block is unnecessary when isIgnoreText() == true Since `clenText` is used in `textHeight` calculation, this cannot be avoided before the `if-else` block as `if-else` block is not re-ordered now. Please refer to the previous comment for the details on `computePrefHeight()` method. ------------- PR: https://git.openjdk.org/jfx/pull/996
