On Mon, 30 Jan 2023 12:21:38 GMT, Karthik P K <k...@openjdk.org> wrote:
> While checking for duplicate series addition to the line chart, `setToRemove` > value was not considered before throwing exception. Hence code to handling > the case of adding the removed series was never run. > > Added condition to check `setToRemove` boolean value before throwing > exception. Made changes to call `setChart` method after calling > `seriesBeingRemovedIsAdded`. Otherwise chart will not be drawn for the > series, only points will be plotted. > > This issue is reproducible only when animation is enabled because timeline > will be still running when removed series is added back to the same chart. > Since timeline does not run in unit tests, added system test to validate the > fix. This pull request has now been integrated. Changeset: de8339d4 Author: Karthik P K <k...@openjdk.org> Committer: Ajit Ghaisas <aghai...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/de8339d45a9e070598fa0ddc91c36fe74c67a956 Stats: 400 lines in 8 files changed: 378 ins; 3 del; 19 mod 8088998: XYChart: duplicate child added exception when remove & add a series in several charts Reviewed-by: aghaisas, angorya ------------- PR: https://git.openjdk.org/jfx/pull/1015
