On Wed, 22 Feb 2023 12:36:44 GMT, Jay Bhaskar <jbhas...@openjdk.org> wrote:

>> Issue: current update is breaking the rendering of media controls on youtube 
>> video playback
>>            For the Webkit Gtk platform, the layout class name is returned as 
>> AdwaitaLayoutTraits
>>            which is incompatible with the JAVA platform.
>> Solution: Use mediaControlsAdwaitaJavaScript and 
>> mediaControlsAdwaitaUserAgentStyleSheet
>>                 which is compatible with RenderThemeJava. 
>> Test: After the fix, open youtube.com and play any video, mouse hover on the 
>> video area, control should come up.
>>          Without the fix, open youtube.com and play any video, mouse hover 
>> on the video area, and the control 
>>           should come up overlapping with each other.
>
> Jay Bhaskar has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   clean up , #if PLATFORM(JAVA) not valid

Looks good. I tested on Windows and the media controls show up again.

Have you tested on both Mac and Linux?

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/1045

Reply via email to