> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this 
> scroll event type, deltas are sent to java with the value equal to zero.
> 
> Here's whats happening:
> 
> We include all event masks, so when using gtk3 (>= 3.4.0) it includes 
> `GDK_SMOOTH_SCROLL_MASK` meaning we receive duplicated events, one with  
> `direction = GDK_SMOOTH_SCROLL_MASK` and other with "legacy" direction 
> (UP/DOWN).
> 
> When receiving the event corresponding to `GDK_SMOOTH_SCROLL_MASK` we ignored 
> it causing it to send deltas (x,y) = 0.
> 
> The fix now checks if `GDK_SMOOTH_SCROLL_MASK` is supported and uses it, also 
> adding smooth scroll functionality.

Thiago Milczarek Sayao has updated the pull request incrementally with one 
additional commit since the last revision:

  Improve direction

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1044/files
  - new: https://git.openjdk.org/jfx/pull/1044/files/88620461..a3975da3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=04
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=03-04

  Stats: 20 lines in 1 file changed: 6 ins; 8 del; 6 mod
  Patch: https://git.openjdk.org/jfx/pull/1044.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/1044/head:pull/1044

PR: https://git.openjdk.org/jfx/pull/1044

Reply via email to