On Wed, 8 Mar 2023 19:36:54 GMT, Phil Race <p...@openjdk.org> wrote: >> This fixes an the AIOOBE when finding a line break point in RTL laid out >> glyphs. >> The comment in the bug report explains how we can end up trying to find an >> unachievable break point and yet there's no "stop" on the search when we've >> run out of glyphs so hence the exception. >> >> The fix uses a different method to choose a break point. >> >> A system test has been supplied which will fail on macOS (even with standard >> macOS fonts, not just the Noto Sans Arabic) unless the fix is applied. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8302797
Looks good with the added timeout and comment. I confirm that the test passes with the fix and fails without. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.org/jfx/pull/1055
