On Tue, 21 Feb 2023 15:18:27 GMT, Martin Fox <[email protected]> wrote:
>> Turning on warnings-as-errors for the macOS glass native code. Deprecated >> declarations are excluded and still appear as warnings. >> >> In the code that tries to locate the application's dock icon there were >> three instances where `NO` was being passed into a method that required a >> pointer to a `BOOL`, not a `BOOL`. I suspect the intent was to check that >> the path pointed to an existing file but not a directory. Since JavaFX has >> gone this long without screening out directories correctly I decided not to >> fix that behavior except at the very end. >> >> The only other changes of note are sending some NSNotification objects to >> delegate API's that require them even though we know they're ignored on the >> other side. It was the easiest way to get rid of the warning. > > Martin Fox has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains two commits: > > - Merge remote-tracking branch 'upstream/master' into macerrors > - Mac Glass treats errors as warnings except for deprecated declarations I'll review this. The large number of warnings can hide a real issue (which I noticed the other day while working on a bug). ------------- PR Comment: https://git.openjdk.org/jfx/pull/687#issuecomment-1492960142
