On Thu, 6 Apr 2023 18:57:34 GMT, Kevin Rushforth <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix NPE
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/coretext/CTFontFile.java
> line 276:
>
>> 274: System.err.println("Cascading list for " + getFullName());
>> 275: }
>> 276: for (int i=0; i<stringInfo.length;i+=2) {
>
> Minor: add space after `;`
done
> modules/javafx.graphics/src/main/native-font/MacFontFinder.c line 255:
>
>> 253: return NULL;
>> 254: }
>> 255: jlong *refArr = calloc(cnt, sizeof(jlong));
>
> I recommend checking the return value for null.
done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1067#discussion_r1160207465
PR Review Comment: https://git.openjdk.org/jfx/pull/1067#discussion_r1160207372
