On Sat, 8 Apr 2023 14:18:56 GMT, Kevin Rushforth <[email protected]> wrote:
>> Add the common base component for all the new implementing native classes
>> Change native peer creation to use the new base component The new code will
>> instantiate new protocol implementation for the given role if it exists or
>> an old one if it does not exist
>> Added BUTTON role implementing class
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacAccessible.java
> line 658:
>
>> 656:
>> 657: MacAccessible() {
>> 658: this.peer = _createGlassAccessible();
>
> Now that you defer the creation of the `peer`, it might be safer to change
> line 798 to call `getNativeAccessible()` instead of accessing `peer`
> directly, in case `sendNotification()` is called before
> `getNativeAccessible()`, unless you know that this can't happen.
Sure, makes sense. Fixing.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1084#discussion_r1162037171
