On Sun, 16 Apr 2023 03:21:59 GMT, Michael Strauß <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix incorrect import
>> - Fix review comments
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/ArrayManager.java
> line 58:
>
>> 56: * Constructs a new instance.
>> 57: *
>> 58: * @param accessor an {@link Accessor}, cannot be {@code null}
>
> There is no `accessor` parameter.
Thanks for all the Javadoc checks; I've turned on some IDE warnings for these
as it turns out they're harder to get right than I thought :) I fixed a couple
more as well.
> modules/javafx.base/src/main/java/com/sun/javafx/binding/ArrayManager.java
> line 374:
>
>> 372: while (needed > max) {
>> 373: min = mid;
>> 374: mid = max;
>
> These two lines don't seem to be useful, as neither `min` nor `mid` are ever
> accessed after this point.
Well spotted, they indeed are not needed in the 2nd loop.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r1167744831
PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r1167744922
