On Mon, 17 Apr 2023 05:05:48 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> I don't know what "visual events" are, maybe input events? >> Anyway, the added value of this entire javadoc seems to be rather low, I'm >> inclined to just remove it entirely. >> >> By the way, there's a great documentation of the JavaFX event system at >> https://docs.oracle.com/javase/8/javafx/events-tutorial/events.htm. It would >> be really helpful if we could add this to the JavaFX codebase in the future. > >> I don't know what "visual events" are, maybe input events? > > I thought something like that too, including scroll and touch events. Maybe > @kevinrushforth knows. > >> Anyway, the added value of this entire javadoc seems to be rather low, I'm >> inclined to just remove it entirely. > > I don't think I mind removing it. My more general concern is that it's not > obvious what events can be registered on different `EventTarget`s. > >> By the way, there's a great documentation of the JavaFX event system at >> https://docs.oracle.com/javase/8/javafx/events-tutorial/events.htm. It would >> be really helpful if we could add this to the JavaFX codebase in the future. > > Yes, I had an idea to link to the tutorials when working on controls > documentation (https://bugs.openjdk.org/browse/JDK-8252550). The problem is > that we don't have access to them and can't update them if they are out of > date. Embedding them is probably too verbose. Linking looks like the better > option. I've removed the documentation from `TableColumnBase` and instead added a paragraph to the class documentation of both `TableColumn` and `TreeTableColumn`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1090#discussion_r1168206290
