On Mon, 24 Apr 2023 11:42:02 GMT, Karthik P K <k...@openjdk.org> wrote:

>> Test was failing because `CountDownLatch` was not used to make sure that new 
>> date is selected and the delay present was not sufficient.
>> If the current date is on the left edge of the date picker, this test would 
>> fail because of the way new date was selected using mouse click.
>> 
>> Added `CountDownLatch` to make sure that alert dialog is closed before 
>> asserting the date. Updated the test to select new date using robot 
>> `keyType` method instead of mouse click so that the test becomes robust.
>> 
>> Ran the test individually and along with all system tests on Mac. No failure 
>> found.
>
> Karthik P K has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add back DatePicker test using mouse and stabilize it

looks good now, thanks!

-------------

Marked as reviewed by angorya (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1104#pullrequestreview-1398455333

Reply via email to