On Mon, 1 May 2023 16:26:36 GMT, Andy Goryachev <[email protected]> wrote:
>> "gradle test" won't rerun a test that has already passed. This is surprising
>> behavior, especially for UI toolkit tests where there might be many reasons
>> to want to run the tests again, even if none of that tests "inputs" have
>> changed. This is especially bothersome when debugging an intermittent test
>> failure. Unlike rebuilding the JavaFX runtime or the docs, where there is no
>> need to rerun a task that was successful if none of the inputs to that task
>> have changed, I expect gradle to run my test when I tell it to.
>>
>> This PR will make test tasks always run when specified.
>
> build.gradle line 2011:
>
>> 2009: // Always run tests
>> 2010: outputs.upToDateWhen { false }
>> 2011:
>
> Should the 'testing' section of
> https://wiki.openjdk.org/display/OpenJFX/Building+OpenJFX
>
> be updated after this PR is integrated?
>
> Are there any other wiki pages that might be impacted?
Updating the testing section is a good idea. Thanks. I'll do that once I
integrate.
I am not aware of any other page that needs to be updated.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1120#discussion_r1181769605
