On Thu, 4 May 2023 23:16:38 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix NaN returns when using Math.ulp
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/layout/ScaledMath.java
> line 18:
>
>> 16: * larger integers with exact precision beyond this limit.
>> 17: *
>> 18: * @param value The value that needs to be floored
>
> is this method only for positive values?
No, it can be used for any value.
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/layout/ScaledMath.java
> line 46:
>
>> 44: * @return value ceiled with scale
>> 45: */
>> 46: public static double ceil(double value, double scale) {
>
> same comment about negative values
No, it can be used for any value.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1118#discussion_r1185803401
PR Review Comment: https://git.openjdk.org/jfx/pull/1118#discussion_r1185803588
