On Fri, 5 May 2023 13:40:39 GMT, Lukasz Kostyra <[email protected]> wrote:
>> Verified these changes on all platforms and saw no abnormalities in test >> execution. >> >> This change is based on a preliminary patch done by @aghaisas , with some >> minor changes and the addition of one Leak-related web test. >> EventListenerLeak test was not touched, as it is a separate manual test app >> instead of a JUnit test. > > Lukasz Kostyra has updated the pull request incrementally with one additional > commit since the last revision: > > Add an EDT no-op and sleep for a bit > > On some platforms Swing memory leak tests occasionally failed, this > might help to mitigate this problem. minor javadoc changes, I'll re-approve if you want to make them. modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 96: > 94: > 95: /** > 96: * Checks whether an array of WeakReference objects can be collected. I think it should rather say something like "whether content of all references in the array", rather than array itself. modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 106: > 104: > 105: /** > 106: * Checks whether a Collection of WeakReference objects can be > collected. same comment: "content of all references in a collection" modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 116: > 114: > 115: /** > 116: * Checks whether provided WeakReference objects can be collected. same comment: "content of references..." ------------- Marked as reviewed by angorya (Committer). PR Review: https://git.openjdk.org/jfx/pull/1121#pullrequestreview-1415078517 PR Review Comment: https://git.openjdk.org/jfx/pull/1121#discussion_r1186274440 PR Review Comment: https://git.openjdk.org/jfx/pull/1121#discussion_r1186274647 PR Review Comment: https://git.openjdk.org/jfx/pull/1121#discussion_r1186277880
