On Tue, 9 May 2023 18:23:15 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/HostServicesDelegate.java
>> line 138:
>>
>>> 136: try {
>>> 137: if (osName.startsWith("Mac OS")) {
>>> 138: Runtime.getRuntime().exec(new String[] {
>>
>> not a review, but a general question:
>> do we have (do we want) an enum identifying the platform?
>
> Don't think we have an enum (maybe we should), but `PlatformUtil` already
> takes care of identifying the OS, also using `System.getProperty("os.name")`.
> You can use `PlatformUtil.isMac()`. If we make an enum, that's where is
> should be.
There was a recent PR
https://github.com/openjdk/jdk/pull/13357
adding an enum deep in the jdk bowels
we probably can't use that
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1130#discussion_r1188986935
