On Thu, 11 May 2023 19:58:18 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains five commits: >> >> - 8295078: Snap anchors as well >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8295078-textfield-blurry >> >> Conflicts: >> >> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AnchorPaneTest.java >> - 8295078: Replace JUnit4 with Junit5 imports >> - 8295078: Adjusted Copyright year >> - 8295078: TextField blurry when inside an TitledPane -> AnchorPane > > modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java > line 349: > >> 347: private double computeChildHeight(Node child, Double topAnchor, >> Double bottomAnchor, double areaHeight, double width) { >> 348: if (topAnchor != null && bottomAnchor != null && >> child.isResizable()) { >> 349: return areaHeight - snappedTopInset() - >> snappedBottomInset() - topAnchor - bottomAnchor; > > same comment about areaHeight - should it be snapSize'd? Well, given that we (should) snap everything including the calculation of the width, I expected that the `areaWidth` and `height`, which are basically `getWidth` and `getHeight` are already snapped. That was at least my thinking back then, not sure now. I need to check everything again since this was a while ago. :) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/910#discussion_r1191651134
