On Fri, 12 May 2023 07:57:27 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:

>> here: yes!
>
> This looks good to me, the snapping as explained by Andy is how it should be. 
>  A source of error can be still be that floating point calculations can 
> introduce small deviations so sometimes it is needed to resnap after doing 
> calculations that seem harmless (ie. `snappedSize * 10` or `snappedWidth - 
> snappedLeftInset` may need resnapping).

Good point. That is something we should think about - this may or may not be a 
problem with some of the snapping code.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/910#discussion_r1192782950

Reply via email to