On Fri, 12 May 2023 10:36:12 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Issue: >> CheckBoxTreeItem extends TreeItem and adds a CheckBox. >> The state of this CheckBox is not visible to an accessibility client >> application. >> If we analyze a simple program that contains a CheckBoxTreeItem using a >> windows application "Accessibility Insights for Window", we can notice that >> toggle state of CheckBox is not exposed. >> >> Fix: >> Include the [Toggle Control >> Pattern](https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-implementingtoggle) >> in Accessibility information of a CheckBoxTreeItem in addition to the >> patterns that are used for a TreeItem. >> >> Verification: >> On Windows: Do the following with and without the fix. >> 1. Run the sample program attached to JBS issue. >> 2. Launch "Accessibility Insights for Window" >> 3. Observe that patterns section for each item >> 4. Select / de-select the CheckBoxes and observe the patterns section for >> correctness of toggle state. > > Ambarish Rapte has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'master' into a11y-8284542-CheckBoxTreeItem > - Review Comment: Add enum ToggleState > - Add CheckBoxTreeItem role and TOGGLE_STATE attribute The additional changes to add the enum look good to me. I'll test it and review the javadoc. ------------- PR Review: https://git.openjdk.org/jfx/pull/1088#pullrequestreview-1425177875
