On Sat, 13 May 2023 16:48:12 GMT, Nir Lisker <[email protected]> wrote:

>> modules/javafx.media/src/main/java/com/sun/media/jfxmediaimpl/HostUtils.java 
>> line 60:
>> 
>>> 58: 
>>> 59:     public static boolean isWindows() {
>>> 60:         return osName.startsWith("windows");
>> 
>> `osName` is unused now
>
> `osArch` is also unused. It's just a local variable.

Yes, but what @nlisker means is that `osArch` does not need to be a member 
variable but only a local one inside the static initializer above.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1134#discussion_r1193014192

Reply via email to