On Tue, 30 May 2023 15:50:17 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Minor fixes and addition of missing sections: >> >> - The 'system' font is missing from the list of generic font family names in >> the <font> section. ✓ >> - Explicitly add text color property -fx-fill to Text section, so as not to >> confuse with Labeled -fx-text-fill ✓ >> - TextFlow section is missing, properties: -fx-text-alignment, >> -fx-line-spacing, -fx-tab-size ✓ >> - Text: missing -fx-line-spacing, -fx-bounds-type ✓ >> - -fx-focus-traversable is in Node and not in Control (though there is some >> relevant comment) - keep as is. ✓ >> - Node: broken link to 'Control' (sic, not Controls) in "... see Controls >> for details" ✓ >> - Missing <text-bounds-type> type ✓ > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > review comments Looks good with one question on `TextFlow`. modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 3155: > 3153: <tr> > 3154: <th colspan="4" class="parents" scope="row">Also has <a > href="#fontprops">font > 3155: properties</a> and all properties of <a > href="#parent">Parent</a></th> Should this be "and all properties of `Pane`"? (or maybe `Region`, since `Pane` adds no properties of its own). ------------- PR Review: https://git.openjdk.org/jfx/pull/1144#pullrequestreview-1454294189 PR Review Comment: https://git.openjdk.org/jfx/pull/1144#discussion_r1212397204
