On Mon, 17 Apr 2023 23:42:37 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move Subscription method for invalidations to Observable
>>
>> - moved Subscription class to the Observable package
>
> modules/javafx.base/src/main/java/javafx/beans/Subscription.java line 51:
>
>> 49: * @throws NullPointerException when {@code subscriptions} is {@code
>> null} or contains {@code null}
>> 50: */
>> 51: static Subscription of(Subscription... subscriptions) {
>
> `combine` sounds like a better name to me.
I agree that `combine` is a better name.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1069#discussion_r1230073055
