On Fri, 23 Jun 2023 15:45:21 GMT, Andy Goryachev <[email protected]> wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> It is important to note that even though the constraints are given by the
>> user in unsnapped coordinates, they are converted to snapped values, since
>> the snapped values correspond to the actual pixels on the display. This
>> means the tests that validate honoring constraints should, in all the cases
>> where (scale != 1.0), assume possibly error not exceeding (1.0 / scale) (I
>> think).
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comments
Left a inline comment.
Otherwise looks good to me
modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ResizeHelper.java
line 112:
> 110: distribute(delta, pref);
> 111: }
> 112: } else if (delta > 0.0) {
Do we need delta = 0.0 condition here?
-------------
Marked as reviewed by kpk (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1156#pullrequestreview-1506543354
PR Review Comment: https://git.openjdk.org/jfx/pull/1156#discussion_r1247456039
