Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v3]

[Andy Goryachev]

On Fri, 7 Jul 2023 17:18:10 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> When the JavaFX scene is set before it is really shown, then the scale 
>> factors are not properly propagated to the EmbeddedWindow, resulting in 
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Set stage scale in FX thread

are you saying that it should show 200% even for the window that gets shown on 
the secondary (scale=1)?
even though the test code does listen to the changes on the right scene instance

        scene.windowProperty().addListener((ob, oldWindow, newWindow) -> {
            newWindow.renderScaleXProperty().addListener((obs, oldValue, 
newValue) -> updateText(label, newValue));
            updateText(label, newWindow.getRenderScaleX());
        });

?

also, the poorly rendered text with the fix - does it mean this PR needs more 
work?

here is the comparison between the master and the fix, using the window that 
appears on the secondary:

![Screenshot 2023-07-07 at 11 43 
49](https://github.com/openjdk/jfx/assets/107069028/8db3f763-810c-4b46-9928-3b0fd3fd78ad)

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1171#issuecomment-1625882313