On Thu, 27 Jul 2023 22:07:40 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> > By the way, the lighting in the LightingSample test application looks a bit > > off to me (regardless of this patch). It's as if the point and spot lights > > are too dim even at close range. Do you also notice that? Might need to > > look at previous revisions to see when it started, > > I'll take a quick look on both Mac and Windows and let you know what I find. Without attenuation, it looks fine to me on both OpenGL and D3D. When I turn on attenuation, it seems like it is attenuated more quickly (and thus dimmer) than I might expect, but I can't be sure. It might be worth checking it against earlier versions (so might need to comment out SpotLight and DirectionalLight so you can go back far enough). It's not related to this PR, though, so I'll approve it now. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1186#issuecomment-1654764621
