On Mon, 31 Jul 2023 22:26:48 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add test case for worker timeout
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/WebWorkerTest.java
> line 50:
>
>> 48: @After
>> 49: public void after() {
>> 50: }
>
> Minor: you don't need this empty method.
done
> modules/javafx.web/src/test/java/test/javafx/scene/web/WebWorkerTest.java
> line 64:
>
>> 62: } catch (InterruptedException e) {
>> 63: // Handle the exception if the thread is interrupted while
>> sleeping
>> 64: }
>
> Minor: if you add `throws InterruptedException` to the test method you don't
> need a try/catch here.
ok
> modules/javafx.web/src/test/java/test/javafx/scene/web/WebWorkerTest.java
> line 69:
>
>> 67: WebView view = getView();
>> 68: String res = (String)
>> view.getEngine().executeScript("document.getElementById('result').innerText;");
>> 69: assertEquals("4",res);
>
> Minor: space after the `,`
done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1191#discussion_r1280380670
PR Review Comment: https://git.openjdk.org/jfx/pull/1191#discussion_r1280380041
PR Review Comment: https://git.openjdk.org/jfx/pull/1191#discussion_r1280380297
