On Tue, 1 Aug 2023 17:02:33 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Yeah, I figured as much. I just don't like code that you can't get covered >> in a unit test, or that contradicts itself. As you can see, I was confused, >> is it a bug or a feature? Perhaps a comment then to indicate that it's >> intentional. > > This is covered in `StepInterpolatorTest.testStart`: the test will assert > that for t<0, the step interpolator produces the expected value. I also added > a comment that this is intended. Thanks for adding the comment, it's fine as is, but I expressed myself unclearly. What I meant is that you can't get full (branch) coverage on the code in the `if`s -- it can't ever happen in its current form -- I didn't mean to imply there was no test for it at all, sorry. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/870#discussion_r1281017545
