On Fri, 18 Aug 2023 17:17:06 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> This PR bumps the limit for the number of javadoc warnings and error from 100 > to 1000. > > We currently use the default setting of javadoc which only shows 100 warnings > and errors. This is too small, especially for warnings, and can cause us to > miss new warnings that arise. Eventually we should fix all our warnings, and > we have a task filed to track that, but even then I think the limit is too > small. > > Without this fix, our current build only shows the "first" 100 warnings it > runs into. With this fix, our current build shows all 187 warnings using JDK > 19.0.2 and all 191 warnings using JDK 21. build.gradle line 4262: > 4260: options.addStringOption("-since-label").setValue("New API since > JavaFX 9") > 4261: options.addStringOption("Xmaxwarns").setValue("1000") > 4262: options.addStringOption("Xmaxerrs").setValue("1000") would it make sense to treat warnings as errors? at least once we fix JBS-TBD to fix all the warnings? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1216#discussion_r1298690844