On Thu, 17 Aug 2023 23:07:14 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> In the Control hierarchy, all property accessor methods must be declared 
> `final`.
> 
> Added a test to check for missing `final` keyword and added the said keyword 
> where required.

Marked as reviewed by jhendrikx (Committer).

modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java
 line 216:

> 214:                 sb.append(c);
> 215:             }
> 216:         }

Suggestion:

       sb.append(prefix);
       sb.append(Character.toUpperCase(name.charAt(0)));
       sb.append(name, 1, name.length);

-------------

PR Review: https://git.openjdk.org/jfx/pull/1213#pullrequestreview-1585264519
PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1298893476

Reply via email to